Force state pickling to use a specific protocol #15611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
jgraham
approved these changes
Mar 1, 2019
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Mar 3, 2019
Force a pickling protocol that will accept certain awkward classes. This cherry-picks the important part of web-platform-tests/wpt#15611 to unbreak the nightly WPT sync. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22961) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Mar 3, 2019
Force a pickling protocol that will accept certain awkward classes. This cherry-picks the important part of web-platform-tests/wpt#15611 to unbreak the nightly WPT sync. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22961) <!-- Reviewable:end -->
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
…cising pickling. (#15611)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://stackoverflow.com/a/2204702/3830 this avoids an exception that occurs when pickling test manifest items and breaks the nightly Servo sync.