Revert "[WPT] BFCache: service worker clients" #34460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 15, 2022
This reverts commit 756b8281b5b76b2ae4561d3cf8c29a46689cf23f. Reason for revert: New tests are very flaky. Example: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVylgELEgVGbGFrZSKKAWNocm9taXVtQGJsaW5rX3dlYl90ZXN0c0BleHRlcm5hbC93cHQvaHRtbC9icm93c2Vycy9icm93c2luZy10aGUtd2ViL2JhY2stZm9yd2FyZC1jYWNoZS9zZXJ2aWNlLXdvcmtlci1jb250cm9sbGVkLWFmdGVyLXJlc3RvcmUuaHR0cHMuaHRtbAw https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyjgELEgVGbGFrZSKCAWNocm9taXVtQGJsaW5rX3dlYl90ZXN0c0BleHRlcm5hbC93cHQvaHRtbC9icm93c2Vycy9icm93c2luZy10aGUtd2ViL2JhY2stZm9yd2FyZC1jYWNoZS9zZXJ2aWNlLXdvcmtlci1jbGllbnRzLW1hdGNoYWxsLmh0dHBzLmh0bWwM Original change's description: > [WPT] BFCache: service worker clients > > This CL adds service worker tests for BFCache: > > - navigator.serviceWorker.controller > - Fetch interception > - Clients.claim() > - Clients.matchAll() and > - unregister(). > > Expected behavior: > > - Controlled pages should remain controlled after > restored from BFCache, i.e. > navigator.serviceWorker.controller should remain non-null > and fetch should be intercepted. > - Clients.claim() should evict pages > that would be affected from BFCache. > - Clients.matchAll() shouldn't list pages in BFCache. > - unregister() should evict controlled pages from BFCache. > > Failing tests: > > - service-worker-clients-claim.https.html: > On Safari/Firefox, Clients.claim() doesn't evict pages from BFCache. > - service-worker-controlled-after-restore.https.html: > On Firefox, fetches are not intercepted after restored from > BFCache while `navigator.serviceWorker.controller` is non-null. > - service-worker-unregister.https.html: > Controlled pages aren't evicted by unregister() (all browsers). > > Bug: 1107415, 1204228, w3c/ServiceWorker#1594 > Change-Id: I73233cf917e31dd91b974823d5490d0190f0eade > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201011 > Reviewed-by: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Ben Kelly <wanderview@chromium.org> > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1008327} Bug: 1107415, 1204228, w3c/ServiceWorker#1594 Change-Id: I56ac20a492e2b1716d27867dc9c113b097833a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3708190 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Phillis Tang <phillis@chromium.org> Auto-Submit: Phillis Tang <phillis@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1014735}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3708190
branch
from
6f8c346
to
214179b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 756b8281b5b76b2ae4561d3cf8c29a46689cf23f.
Reason for revert: New tests are very flaky. Example:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVylgELEgVGbGFrZSKKAWNocm9taXVtQGJsaW5rX3dlYl90ZXN0c0BleHRlcm5hbC93cHQvaHRtbC9icm93c2Vycy9icm93c2luZy10aGUtd2ViL2JhY2stZm9yd2FyZC1jYWNoZS9zZXJ2aWNlLXdvcmtlci1jb250cm9sbGVkLWFmdGVyLXJlc3RvcmUuaHR0cHMuaHRtbAw
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyjgELEgVGbGFrZSKCAWNocm9taXVtQGJsaW5rX3dlYl90ZXN0c0BleHRlcm5hbC93cHQvaHRtbC9icm93c2Vycy9icm93c2luZy10aGUtd2ViL2JhY2stZm9yd2FyZC1jYWNoZS9zZXJ2aWNlLXdvcmtlci1jbGllbnRzLW1hdGNoYWxsLmh0dHBzLmh0bWwM
Original change's description:
Bug: 1107415, 1204228, w3c/ServiceWorker#1594
Change-Id: I56ac20a492e2b1716d27867dc9c113b097833a6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3708190
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Phillis Tang <phillis@chromium.org>
Auto-Submit: Phillis Tang <phillis@chromium.org>
Commit-Queue: Phillis Tang <phillis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1014735}