-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a check if substitutions
exists
#46945
base: master
Are you sure you want to change the base?
Conversation
Why is the argument undefined, though? |
I do not know why. Here's a simple way to reproduce the issue.
|
I took a brief look at the source. In L4514: function render(template, substitutions, output_document)
However, for example, in L4290, only 1 argument is specified. const asserts_output = render(
["details", {},
["summary", {}, "Asserts run"],
["table", {}, ""] ]); By the way, the previous PR had an array as the default value, which was a mistake. substitutions = {
[components[i + 1]]: foo
} So, fixed default value to |
substitute_single
functionsubstitutions
exists
Ready for review now. Some notes about the issue:
On the other hand, in the internal function Therefore, if |
Fix #46940