Fix input type for forward delete input event #46947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A |TypingCommand| is created to execute corresponding input command and and is reused until it is open for typing. |TypingCommand::ForwardDeleteKeyPressed()| was reusing last typing command without resetting its input type, which is fixed in this CL. Bug: 40736701 Change-Id: I5ca6ed8c3028c90cd32a4d206772bcf9a5d48b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5653570 Reviewed-by: Siye Liu <siliu@microsoft.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Sanket Joshi <sajos@microsoft.com> Commit-Queue: Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1321543}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5653570
branch
from
4f6319c
to
b97b325
Compare
wpt-pr-bot
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A |TypingCommand| is created to execute corresponding input command and
and is reused until it is open for typing.
|TypingCommand::ForwardDeleteKeyPressed()| was reusing last typing
command without resetting its input type, which is fixed in this CL.
Bug: 40736701
Change-Id: I5ca6ed8c3028c90cd32a4d206772bcf9a5d48b2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5653570
Reviewed-by: Siye Liu <siliu@microsoft.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Sanket Joshi <sajos@microsoft.com>
Commit-Queue: Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1321543}