[reading-flow] Display: contents elements can be focusable #46953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSSWG has resolved that reading-flow does not affect whether an element is focusable. Given this, we should remove the check in Element that forbids display: contents with reading-flow to be focusable. We update the FocusNavigation logic such that the display: contents elements are visited last, after all reading flow items found within the layout box. Change-Id: Iadd9636166628361b001df7b63b2ee98072a89d5 Bug: 346979043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5656691 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Di Zhang <dizhangg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1321829}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5656691
branch
from
b87e3a1
to
02c2a80
Compare
wpt-pr-bot
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSSWG has resolved that reading-flow does not affect whether an element
is focusable. Given this, we should remove the check in Element that
forbids display: contents with reading-flow to be focusable.
We update the FocusNavigation logic such that the display: contents
elements are visited last, after all reading flow items found within the
layout box.
Change-Id: Iadd9636166628361b001df7b63b2ee98072a89d5
Bug: 346979043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5656691
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1321829}