Reland "[text-decorations] Fix a crash for ::first-line"
#47012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a reland of commit c9d2271396f178e2c0747f2ef2ac727d8a02f9d1 The original CL hits a `DCHECK` in the `linux-autofill-captured-sites-rel` bots. This CL changes to push 2 decoration boxes only when the conditions are known, and to fall back to 1 decoration box in other cases. This CL also puts the changes under a runtime flag. Original change's description: > [text-decorations] Fix a crash for `::first-line` > > This patch fixes a crash when `text-decoration` is applied to > `::first-line`. > > Fixed: 345562934 > Change-Id: If26564ca3dcb913236771ef4a634928485b68eca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5677308 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Auto-Submit: Koji Ishii <kojii@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1323270} Change-Id: Ifb27df1bfd8e9d0a9dc37a1f18d27a6c9488cc29 Fixed: 345562934 Cq-Include-Trybots: luci.chrome.try:linux-autofill-captured-sites-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5678276 Reviewed-by: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1323484}
wpt-pr-bot
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of commit c9d2271396f178e2c0747f2ef2ac727d8a02f9d1
The original CL hits a
DCHECKin thelinux-autofill-captured-sites-relbots. This CL changes topush 2 decoration boxes only when the conditions are known,
and to fall back to 1 decoration box in other cases.
This CL also puts the changes under a runtime flag.
Original change's description:
Change-Id: Ifb27df1bfd8e9d0a9dc37a1f18d27a6c9488cc29
Fixed: 345562934
Cq-Include-Trybots: luci.chrome.try:linux-autofill-captured-sites-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5678276
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1323484}