Improve <selectedoption> performance #47467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5758741
branch
from
9344c80
to
6932a7c
Compare
This patch improves the performance of <selectedoption> by replacing the SynchronousMutationObserver with the existing async MutationObserver in HTMLOptionElement. The change from sync to async impacts some tests. The timing is being discussed in a standards issue here: whatwg/html#10520 Fixed: 336844298 Change-Id: I9693de9cf35913e7daaebb364c4923dcd4a2dc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5758741 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1337462}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5758741
branch
from
6932a7c
to
c24f4fb
Compare
wpt-pr-bot
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the performance of <selectedoption> by replacing the
SynchronousMutationObserver with the existing async MutationObserver in
HTMLOptionElement.
The change from sync to async impacts some tests. The timing is being
discussed in a standards issue here:
whatwg/html#10520
Fixed: 336844298
Change-Id: I9693de9cf35913e7daaebb364c4923dcd4a2dc39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5758741
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1337462}