Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WPT tests validating BeginLayerOptions filters tentative #48477

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 4, 2024

The beginLayer's BeginLayerOption parameter was removed from the canvas
layer PR at whatwg/html#9537. We might pursue
this as a followup. In the meantime, the tests validating filters
specified via BeginLayerOptions should be marked as tentative.

Bug: 40249439
Change-Id: I3d9a009abc04658395b403a8752cf065644fc7f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5903952
Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org>
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1364414}

The beginLayer's BeginLayerOption parameter was removed from the canvas
layer PR at whatwg/html#9537. We might pursue
this as a followup. In the meantime, the tests validating filters
specified via BeginLayerOptions should be marked as tentative.

Bug: 40249439
Change-Id: I3d9a009abc04658395b403a8752cf065644fc7f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5903952
Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org>
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1364414}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 13948ad into master Oct 4, 2024
20 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-5903952 branch October 4, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants