Skip to content

Releases: web-platform-tests/wpt

merge_pr_48472

05 Oct 18:35
9448ab3
Compare
Choose a tag to compare

merge_pr_48466

05 Oct 09:35
Compare
Choose a tag to compare

Ignore transform-origin and such shenanigans in SVGGeometryElement::LocalTransform.

We don't want the offsetted matrix, just the actual transform matrix
specified on the element.

Differential Revision: https://phabricator.services.mozilla.com/D224217

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921662
gecko-commit: dd364824053b80e505688cfb4bf8a2f17b70019a
gecko-reviewers: longsonr

merge_pr_48485

04 Oct 23:55
Compare
Choose a tag to compare

[A11y] Remove Accessibility Object Model (AOM)

Follow-ups will completely remove AccessibleNode, which is still used
for its static methods for ARIA property retrieval in ordinary

situations.

Bug: 369945541
Change-Id: If4201088b86de9a88e1b611fae2e88a8ba3439ac
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5896593
Reviewed-by: Tzarial zork@chromium.org
Reviewed-by: Demetrios Papadopoulos dpapad@chromium.org
Reviewed-by: Richard (Torne) Coles torne@chromium.org
Reviewed-by: Nico Weber thakis@chromium.org
Reviewed-by: Chris Harrelson chrishtr@chromium.org
Commit-Queue: Daniel Cheng dcheng@chromium.org
Reviewed-by: Daniel Cheng dcheng@chromium.org
Reviewed-by: Alex Moshchuk alexmos@chromium.org
Reviewed-by: Mason Freed masonf@chromium.org
Auto-Submit: Aaron Leventhal aleventhal@chromium.org
Cr-Commit-Position: refs/heads/main@{#1364497}

merge_pr_48483

04 Oct 23:30
Compare
Choose a tag to compare

Group WPT canvas layer clip tests together in the YAML file

The tests 2d.layer.clip-inside and 2d.layer.clip-inside-and-outside
got separated from 2d.layer.clip-outside by a previous CL. This CL
groups them together. The code is unchanged.

Bug: 40249439
Change-Id: I369ddf194e2fadb2d2ee658ae86ffb5ddc0c9648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5910129
Reviewed-by: Andres Ricardo Perez andresrperez@chromium.org
Commit-Queue: Jean-Philippe Gravel jpgravel@chromium.org
Cr-Commit-Position: refs/heads/main@{#1364480}

merge_pr_48482

04 Oct 23:55
Compare
Choose a tag to compare

[line-clamp] Always clamp immediately after a line box

In our initial implementation of line-clamp: auto, we allowed
clamping after lineless boxes, in order to better match the behavior
of line-clamp as it follows from the spec's continue: discard
model, even though our implementation uses a different model which is
not yet in the specification (see
w3c/csswg-drafts#7708).

However, in hallway conversations in TPAC 2024, we agreed that it
would be better for this model to instead only allow clamping
immediately after a line. If the first line does not fit, we calmp at
the first line even if that overflows the clamp height. If there are
no lines, we do not clamp. This patch implements this.

Additionally, a previous patch (https://crrev.com/c/5868971) had
increased the memory size of LineClampData from 8 to 20 bytes,
causing a memory regression. This patch shrinks it to 12 bytes, since
LineClampData no longer needs to keep track of how many block boxes
there are between the last line and the clmap point, and now OOFs
after the clamped line behave the same when clamping by a number of
lines or by a height, so there is no need for a flag to distinguish
these behaviors. This patch also adds a size assertion for
LineClampData.

This patch also changes or removes some WPT tests that were written
assuming the previous behavior.

Bug: 40336192, 368114054
Change-Id: I8c8afebb5dc566de92112cee2fcf24a2e60b42c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5904459
Reviewed-by: Ian Kilpatrick ikilpatrick@chromium.org
Commit-Queue: Andreu Botella abotella@igalia.com
Cr-Commit-Position: refs/heads/main@{#1364495}

merge_pr_48478

04 Oct 19:13
Compare
Choose a tag to compare

compute pressure: Rewrite rate obfuscation web tests as unit tests

These tests have been flaky since they have been rewritten to use
WebDriver (bug 347031400). https://crrev.com/c/5898989 added them to
SlowTests, but that did not work: contrary to what I expected, marking a
test as long in WPT's metadata and adding it to SlowTests are
idempotent, not cumulative operations (i.e. I thought adding a test to
SlowTests would increase the timeout even more, but it's just a no-op if
the test is already marked as long).

However, after investigating it further I believe this is not just a
timeout problem: these tests cannot work anymore by definition. The idea
of these tests is to send a number of updates and verify that:

  • Sending a number of updates smaller than the spec-defined threshold to
    trigger the mitigations causes the difference between
    PressureRecord.time in subsequent updates to be smaller than the
    penalty time.

  • Sending a number of updates greater than the spec-defined threshold
    does trigger the mitigation and cause update N within a spec-defined
    range to be sent with an implementation-defined delay.

In all cases, we need to send an update to WebDriver and verify that
PressureObserver has received it before sending the next one.
Consequently, the time it takes between sending and receiving updates is
actually outside the test's control: busy bots (such as the mac-rel and
win-rel ones) can simply cause the web test to WebDriver or the
WebDriver to browser process communication to take arbitrarily long,
leading to:

  • Measured time between updates that should not trigger a penalty still
    taking longer than allowed because the system took too long to deliver
    the update_virtual_pressure_source() call. This causes the "not
    triggered" test to fail and leads to false positives in the
    "triggered" test.

  • Calls to update_virtual_pressure_source() taking too long to be on the
    browser side so that and/or too few updates being sent from the
    browser side while waiting under penalty so that the difference
    between the pre-penalty update's timestamp and the
    update-under-penalty's timestamp ends up being less than the minimum
    penalty time. This makes the "triggered" test never flip the
    |gotPenalty| flag to true.

This was not a problem in the past because the MojoJS-based tests were
restricted to Blink.

The only way to have full control over the timing is to use unit tests
where we can have a mock time source that we move forward as we see fit.

Bug: 370726578, 347031400
Change-Id: I9b21513c7b8e83177e7d7b091607100d0cd21c87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5909373
Reviewed-by: Reilly Grant reillyg@chromium.org
Auto-Submit: Raphael Kubo Da Costa raphael.kubo.da.costa@intel.com
Commit-Queue: Reilly Grant reillyg@chromium.org
Commit-Queue: Raphael Kubo Da Costa raphael.kubo.da.costa@intel.com
Cr-Commit-Position: refs/heads/main@{#1364368}

merge_pr_48477

04 Oct 21:15
Compare
Choose a tag to compare

Make WPT tests validating BeginLayerOptions filters tentative

The beginLayer's BeginLayerOption parameter was removed from the canvas
layer PR at whatwg/html#9537. We might pursue
this as a followup. In the meantime, the tests validating filters
specified via BeginLayerOptions should be marked as tentative.

Bug: 40249439
Change-Id: I3d9a009abc04658395b403a8752cf065644fc7f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5903952
Reviewed-by: Andres Ricardo Perez andresrperez@chromium.org
Commit-Queue: Jean-Philippe Gravel jpgravel@chromium.org
Cr-Commit-Position: refs/heads/main@{#1364414}

merge_pr_48474

04 Oct 16:38
Compare
Choose a tag to compare

FLEDGE: Restore backwards compat on null on our Promise params

...after Chrome's WebIDL impl tightened up checking on those[1]
(and pointed out that our spec is wrong on these, will work to
update it after this CL).

I am unsure as to what to do with resolvedToConfig, though; the
behavior of it is very non-JS-like.

[1] See https://chromium-review.googlesource.com/c/chromium/src/+/5381805

Change-Id: I92abd0bf34601333064b9e1c5b4a21ea4068754f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907125
Reviewed-by: Qingxin Wu qingxinwu@google.com
Commit-Queue: Maks Orlovich morlovich@chromium.org
Cr-Commit-Position: refs/heads/main@{#1364237}

merge_pr_48473

04 Oct 18:25
Compare
Choose a tag to compare

Style support for the CSS caret-animation property

Add the CSS caret-animation property, behind the CSSCaretAnimation
runtime feature. The property does not have any effect yet.

See https://chromestatus.com/feature/5082469066604544

Bug: 329301988
Change-Id: I1a9e33ad0f8f7b0e576157c6945227c6d14de86b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905981
Commit-Queue: Stephen Chenney schenney@chromium.org
Reviewed-by: Anders Hartvoll Ruud andruud@chromium.org
Cr-Commit-Position: refs/heads/main@{#1364320}

merge_pr_48470

04 Oct 14:40
Compare
Choose a tag to compare

DOM: Ensure atomic moves trigger relevant mutations

See
https://docs.google.com/document/d/1qfYyvdK4zhzloABKeh0K1lHPm-SpnEcsWEE9UdDuoMk/edit and the discussion around , ,and relevant mutations during atomic moves.

R=nrosenthal@chromium.org

Bug: 40150299
Change-Id: I7c7de31da763efd9a17cf5258e1c4be9e54c907b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906482
Reviewed-by: Noam Rosenthal nrosenthal@chromium.org
Commit-Queue: Dominic Farolino dom@chromium.org
Cr-Commit-Position: refs/heads/main@{#1364197}