Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release please for API should be triggered on DB commit #1275

Open
vasco-santos opened this issue Apr 26, 2022 · 0 comments
Open

Release please for API should be triggered on DB commit #1275

vasco-santos opened this issue Apr 26, 2022 · 0 comments
Labels
effort/quickwin kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up potential/support-pi

Comments

@vasco-santos
Copy link
Contributor

Currently API tests on DB commit changes but the release please PR is not created. See #1274 for example.

It looks like release please does not support multiple paths to analyse if previous commits had changes there. Did not spend much time on it, but we need to find a solution to have API release PR triggered when DB changes too
@vasco-santos vasco-santos added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Apr 26, 2022
@dchoi27 dchoi27 added potential/support-pi effort/quickwin P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels May 26, 2022
olizilla added a commit that referenced this issue Jun 27, 2022
@olizilla
chore: release-please for db
5f9dca6 
this is a nudge to finish off the db migration automation.

as is, this will add release please notes to the PRs and increment the package number.

If we do a major change, we'd need to bump the db dep number in the other projects.

TODO:
- [ ] fork prod db to staging on merge to main
- [ ] auto apply migrations to staging
- [ ] snapshot prod db on release
- [ ] auto apply migrations to prod

see: #1482
see: #1275

License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans <oli@tableflip.io>
@olizilla olizilla mentioned this issue Jun 27, 2022
Draft
5 tasks
@vasco-santos vasco-santos mentioned this issue Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/quickwin kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up potential/support-pi
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vasco-santos @dchoi27