Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the user experience around displaying the pins table in the account section #1947

Open
1 of 3 tasks
joshJarr opened this issue Sep 26, 2022 · 2 comments · May be fixed by #2147
Open
1 of 3 tasks

Improve the user experience around displaying the pins table in the account section #1947

joshJarr opened this issue Sep 26, 2022 · 2 comments · May be fixed by #2147
Assignees
@alexandrastoica
Labels
topic/pagination topic/pot Issues handled by PT.

Comments

@joshJarr
Copy link
Contributor

joshJarr commented Sep 26, 2022 •
edited by francois-potato
Loading

Acceptance criteria:

  • I want to be able to see all my pins and their state
  • If I have pinning enabled, I want to see the pins table (whether I already created pins or not)
  • The behavior is consistent with REST APIs, if I don't have access to PSA I won't see the table in the UI.

Notes

Upon logging in with a user without PSA enabled, a redundant call is made to the /pins endpoint to fetch user pins.
We should be able to avoid this by checking the user HAS_PSA_ENABLED flag.
@mbommerez mbommerez changed the title Redundant call made to fetch pins on account page load Improve the user experience around displaying the pins table in the account section Oct 28, 2022
@mbommerez
Copy link

Note: we need to double check these criteria before starting work on them

@alexandrastoica alexandrastoica self-assigned this Nov 21, 2022
alexandrastoica pushed a commit that referenced this issue Dec 5, 2022
fix: improve pins vs uploads experience on account page #2117 #1947
7c2fdbd
@alexandrastoica alexandrastoica linked a pull request Dec 5, 2022 that will close this issue
Open
@alexandrastoica alexandrastoica linked a pull request Dec 5, 2022 that will close this issue
fix: improve pins vs uploads experience on account page #2117 #1947 #2147
Open
@alexandrastoica alexandrastoica mentioned this issue Dec 5, 2022
Draft
@alexandrastoica
Copy link
Contributor

Last two points are in #2147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandrastoica alexandrastoica

Labels
topic/pagination topic/pot Issues handled by PT.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve pins vs uploads experience on account page #2117 #1947 web3-storage/web3.storage
3 participants
@alexandrastoica @joshJarr @mbommerez