Skip to content

Commit

Permalink
update changelog files and a type
Browse files Browse the repository at this point in the history
  • Loading branch information
Muhammad-Altabba committed Mar 24, 2024
1 parent 60f0e2e commit e43939f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
4 changes: 4 additions & 0 deletions packages/web3-eth-contract/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -369,3 +369,7 @@ Documentation:
### Added

- Types `ContractDeploySend`, `ContractMethodSend` was added (#6883)

### Fixed

- Fix an issue with smart contract function overloading (#6922)
6 changes: 5 additions & 1 deletion packages/web3-types/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -189,4 +189,8 @@ Documentation:

- Type `FeeData` to be filled by `await web3.eth.calculateFeeData()` to be used with EIP-1559 transactions (#6795)

## [Unreleased]
## [Unreleased]

### Added

- Added `signature` to type `AbiFunctionFragment` (#6922)
2 changes: 1 addition & 1 deletion packages/web3-types/src/eth_abi_types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export type AbiFunctionFragment = AbiBaseFragment & {
readonly constant?: boolean; // stateMutability == 'pure' or stateMutability == 'view'
readonly payable?: boolean; // stateMutability == 'payable'

readonly signature: string;
readonly signature?: string;
};

export type AbiFallbackFragment = AbiBaseFragment & {
Expand Down

1 comment on commit e43939f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: e43939f Previous: 6c075db Ratio
processingTx 9324 ops/sec (±4.06%) 9301 ops/sec (±4.81%) 1.00
processingContractDeploy 37219 ops/sec (±7.77%) 39129 ops/sec (±7.62%) 1.05
processingContractMethodSend 19382 ops/sec (±6.21%) 19443 ops/sec (±5.19%) 1.00
processingContractMethodCall 39859 ops/sec (±4.94%) 38971 ops/sec (±6.34%) 0.98
abiEncode 43336 ops/sec (±7.53%) 44252 ops/sec (±6.92%) 1.02
abiDecode 30504 ops/sec (±6.57%) 30419 ops/sec (±8.89%) 1.00
sign 1578 ops/sec (±3.82%) 1656 ops/sec (±4.08%) 1.05
verify 374 ops/sec (±0.64%) 373 ops/sec (±0.78%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.