Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix eth abi typings #4937

Closed
wants to merge 3 commits into from
Closed

Conversation

chancehudson
Copy link

@chancehudson chancehudson commented Apr 12, 2022

Description

Copy of #4100

@avkos @nazarhussain Can we push this through? It's been a year and this is a pretty simple type change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@jdevcs jdevcs added the 1.x 1.0 related issues label Apr 13, 2022
@jdevcs jdevcs added the Review Needed Maintainer(s) need to review label Apr 13, 2022
@jdevcs
Copy link
Contributor

jdevcs commented Apr 13, 2022

Related to #3587

@coveralls
Copy link

coveralls commented Apr 13, 2022

Pull Request Test Coverage Report for Build 2162224791

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 265 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.3%) to 74.495%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 7 85.42%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-utils/src/utils.js 44 9.66%
packages/web3-eth-accounts/src/index.js 107 23.67%
Totals Coverage Status
Change from base Build 2162197348: 2.3%
Covered Lines: 3242
Relevant Lines: 4107

💛 - Coveralls

@avkos avkos requested a review from nazarhussain April 14, 2022 14:07
@avkos
Copy link
Contributor

avkos commented Apr 15, 2022

create a copy of this PR and close

@avkos avkos closed this Apr 15, 2022
@jdevcs jdevcs mentioned this pull request Apr 19, 2022
16 tasks
@jdevcs jdevcs mentioned this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants