Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix example of tx usage #5402

Merged
merged 8 commits into from
Sep 7, 2022
Merged

docs: Fix example of tx usage #5402

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ba16106
docs: Fix example of tx usage
acolytec3 Aug 30, 2022
ee42156
chore: update changelog
acolytec3 Aug 30, 2022
36707c0
Merge branch '1.x' into tx-usage
nikoulai Aug 31, 2022
9cc3f65
Fix changelog
acolytec3 Sep 6, 2022
b001b19
Merge branch '1.x' into tx-usage
acolytec3 Sep 6, 2022
ac9edf1
Merge branch '1.x' into tx-usage
avkos Sep 6, 2022
be4b667
Add example entry back
acolytec3 Sep 7, 2022
9369e45
Merge branch '1.x' into tx-usage
jdevcs Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 2 additions & 30 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,36 +4,6 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

<!-- EXAMPLE

## [1.0.0]

### Added

- I've added feature XY (#1000)

### Changed

- I've cleaned up XY (#1000)

### Deprecated

- I've deprecated XY (#1000)

### Removed

- I've removed XY (#1000)

### Fixed

- I've fixed XY (#1000)

### Security

- I've improved the security in XY (#1000)

-->

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example template shouldn't be removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, removed it in error. I've added it back

## [1.2.0]

Released with 1.0.0-beta.37 code base.
Expand Down Expand Up @@ -590,6 +560,8 @@ Released with 1.0.0-beta.37 code base.
### Changed
- Updated `sha3` and `sha3Raw` type definition to accept `Buffer`
- Removing legacy field in lerna.json (#5403)
- Correct `eth_sendSignedTransaction` code example (#5402)


### Fixed
- Browser builds support polyfills (#5031) (#5053) (#4659) (#4767)
Expand Down
4 changes: 2 additions & 2 deletions docs/web3-eth.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,9 +1664,9 @@ Example
}

var tx = new Tx(rawTx, {'chain':'ropsten'});
tx.sign(privateKey);
var signedTx = tx.sign(privateKey);
jdevcs marked this conversation as resolved.
Show resolved Hide resolved

var serializedTx = tx.serialize();
var serializedTx = signedTx.serialize();

// console.log(serializedTx.toString('hex'));
// 0xf889808609184e72a00082271094000000000000000000000000000000000000000080a47f74657374320000000000000000000000000000000000000000000000000000006000571ca08a8bbf888cfa37bbf0bb965423625641fc956967b81d12e23709cead01446075a01ce999b56a8a88504be365442ea61239198e23d1fce7d00fcfc5cd3b44b7215f
Expand Down