Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge block tags support 5199 #5410

Merged
merged 22 commits into from
Sep 7, 2022
Merged

Merge block tags support 5199 #5410

merged 22 commits into from
Sep 7, 2022

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Sep 1, 2022

Description

#5199

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

@jdevcs jdevcs added the 1.x 1.0 related issues label Sep 1, 2022
@jdevcs jdevcs self-assigned this Sep 1, 2022
@render
Copy link

render bot commented Sep 1, 2022

@jdevcs jdevcs marked this pull request as ready for review September 5, 2022 14:52
@jdevcs
Copy link
Contributor Author

jdevcs commented Sep 6, 2022

Discussion point: finalized is not made as default block tag in 1.x as it will be breaking change and also this lib might be used with other POW networks. This and other breaking changes are and will be included in next major bump ( 4.x ), so we can make finalized as default block tag in 4.x. 1.x users can set this via https://web3js.readthedocs.io/en/v1.7.5/web3-eth.html#id14

@jdevcs jdevcs added the Future Release For future release. label Sep 6, 2022
This was referenced Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Future Release For future release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants