Nikos/5430/validator unit test coverage #5525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikoulai
requested review from
avkos,
jdevcs,
luu-alex,
Muhammad-Altabba and
spacesailor24
|
I've added some |
jdevcs
reviewed
Oct 17, 2022
packages/web3-validator/src/utils.ts
Outdated
| @@ -218,6 +218,7 @@ export const transformJsonDataToAbiFormat = ( | |||
| abiName = abi.name; | |||
| abiComponents = abi.components as FullValidationSchema; | |||
| // If its short form string value e.g. ['uint'] | |||
| // todo abis is FullValidationSchema aka ReadOnlyArray<AbiParameter>, thus abi cannot be something else, so may next two ifs are reduntant | |||
There was a problem hiding this comment.
Next two if are checking internal members of abis that is not complete abi type, and also not abis param it self.
jdevcs
approved these changes
Oct 17, 2022
avkos
approved these changes
Oct 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5430 validator unit tests coverage (78% -> 91.52%)
Checklist for 4.x:
yarnsuccessfullyyarn lintsuccessfullyyarn build:websuccessfullyyarn test:unitsuccessfullyyarn test:integrationsuccessfullycompile:contractssuccessfullyCHANGELOG.mdfile in the packages I have edited.