-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: _jsonInterfaceMethodToString export in types #5550
Fix: _jsonInterfaceMethodToString export in types #5550
Conversation
Pull Request Test Coverage Report for Build 3416365903Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Can we merge this or is anything blocking atm? |
Thanks @zlumer for your contribution. |
From what I can see in the logs, the problem seems to be with the infura connection. Not sure if this has something to do with a simple one-character typings change. Do any of the other PRs have the same problem?
|
I just checked the Dependabot PRs (e.g. #5551) and they have the same error in the logs. I suspect it may be the effect of The Merge and the testnet deprecation by Infura: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zlumer,
Yes, it seems to be an irrelevant issue in the pipeline. And I created an issue for this based on your comment.
And I think this MR is good to go once we have additional approval from the team.
Could you please update the CHAINLOG.md file? |
Done 🙂 |
CHANGELOG.md
Outdated
@@ -609,6 +609,7 @@ Released with 1.0.0-beta.37 code base. | |||
|
|||
- Fixed types for getPastEvents (#4955) (#5260) | |||
- Fix Log type by adding missing `removed` property (#4877) | |||
- Fixed types for `web3.utils._jsonInterfaceMethodToString` (#5550) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly rebase your branch and put this under unreleased 1.8.2
. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Should I squash commits now or during the PR merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
squash commits will happen during pr merge
Found a TypeScript export error in web3.js v1.x
web3.utils.jsonInterfaceMethodToString
is exported with underscore in JS. In TS types however the underscore is not present.Steps to reproduce:
This PR fixes this error in web3.js 1.x