Nikos/fix ens event test #5880
Merged
Nikos/fix ens event test #5880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/web3.js into nikos/4898/ens-system-tests
Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
github-actions
bot
temporarily deployed
to
Preview: (nikos/fix-ens-event-test)
Deploying with
|
| Latest commit: |
1cb087d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://75a40222.web3-js-docs.pages.dev |
| Branch Preview URL: | https://nikos-fix-ens-event-test.web3-js-docs.pages.dev |
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed No assets were removed Bigger
Smaller
Unchanged
|
github-actions
bot
temporarily deployed
to
Preview: (nikos/fix-ens-event-test)
github-actions
bot
temporarily deployed
to
Preview: (nikos/fix-ens-event-test)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #5880 +/- ##
=======================================
Coverage 80.03% 80.03%
=======================================
Files 136 136
Lines 5899 5899
Branches 1537 1537
=======================================
Hits 4721 4721
Misses 1178 1178
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nikoulai
requested review from
avkos,
jdevcs,
luu-alex,
Muhammad-Altabba and
spacesailor24
avkos
approved these changes
Feb 28, 2023
spacesailor24
approved these changes
Mar 1, 2023
spacesailor24
pushed a commit
that referenced
this pull request
Mar 9, 2023
* Expose registry events in ens class * Add tests for events * Check for socket * Skip test * Try to unskip test * skip test again * Update packages/web3-eth-ens/test/integration/ens.events.test.ts Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com> * feedback * Try fix * Merge branch '4.x' * Revert conf files * Remove error for event --------- Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com> Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
spacesailor24
added a commit
that referenced
this pull request
Mar 9, 2023
* Add payload as optional argument for InvalidResponseError * Init Transaction Error Scenarios tests * Init ERR_TX_REVERT_TRANSACTION_CUSTOM_ERROR * WIP * WIP * Update TransactionRevertedWithoutReasonError to handle receipts objects with BigInts * Update sendTransaction revert tests * Add contractAbi argument to getTransactionError * sendTransation emits error for ContractExecutionError * Add ContractExecutionError to SendTransactionEvents. Add contractAbi to SendTransactionOptions * Replace use of contractExecutionError sendTransaction event with error * Update contract_methods reverts test * Update web3-errors test * Update expected error mesage for contract_deploy_test * Add expectedErrorObject based on test backend * Correct web3-errors test snapshots * fix (#5869) * 5747 codecov (#5843) * code cov integration for unit tests * removed cov threshold * code cov token * by default collect coverage * codecov with existing unittests * jest config * only analyze coverage for n v16 unit test runs * node ver * codecov paths config * added layout * common config * flag names in ci * flags under proj * min CI for test * build and test for u14 and 16 * validated yml * components usage * comment moved at end * updated comments * testing 90% cov target * component cov target * patch cov * enable actions + remove old coverage check actions * codecov config change * remove unused scripts * ens system tests (#5849) * Expose registry events in ens class * Add tests for events * Check for socket * Skip test * Try to unskip test * skip test again * Update packages/web3-eth-ens/test/integration/ens.events.test.ts Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com> * feedback --------- Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com> Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com> * Disconnect function doesn't exists in types of currentProvider (#5865) * fix disconnect function * add link * test types * add disconnect function test * fix eth tests * test stuck * trace * fix * check * fix test * add empty disconnect function * add test for provider instances * fix http unit test * remove logs * revert to throw error http provider --------- Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com> * Nikos/fix ens event test (#5880) * Expose registry events in ens class * Add tests for events * Check for socket * Skip test * Try to unskip test * skip test again * Update packages/web3-eth-ens/test/integration/ens.events.test.ts Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com> * feedback * Try fix * Merge branch '4.x' * Revert conf files * Remove error for event --------- Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com> Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com> * update event emitter geth ipc tests (#5874) * update geth binary tests * update helper and changelog * adding await * update helper * add await * add await * add await * fix typings * update tests * update * debug * remove debugging * 4.x issue stale conf (#5878) * Add documentation for catching provider events (#5886) * show Ipc and WebSocket providers in the documentation * add guides for providers and their events * move the generic section of the providers guide from the migration guide * edit some texts in the guides * Fixing tests for WS and IPC * Remove jest specific test code that doesn't work in Cypress * Remove jest specific test code that doesn't work in Cypress * Remove jest specific test code * Add toLowerCase for address * Rename TransactionRevertError to TransactionRevertInstructionError * Add beforeAll for Transaction Error Scenario tests * Add Transaction Error Scenario tests for call * Add support for handleRevert in sendTransaction for geth * Update tests and add test to verify event error is same as thrown error * Correct test expected data * Remove message from expectedThrownError for sendTransaction tests * Add error refactors to sendSignedTransaction and init tests * Remove call Transaction Error Scenario tests * Fix type error * Fix nonce issue in tests * Fix error parsing bug for web3Eth.sendSignedTransaction * Update expected error for send_signed_transaction error tests * Revert ResponseError change to maintain 1.x parity * Add web3-errors test for TransactionRevertWithCustomError * Update expected error message for RespnoseError in web3-eth-contract tests * Add example to dev comment for sendSignedTransaction * Removed implemented TODO in packages/web3-eth/src/utils/get_transaction_error.ts * Update CHANGELOGs * Update CHANGELOG.md * Init get_transaction_error tests * Add mock to getRevertReason for get_transaction_error tests * Init getRevertReason tests and parseTransactionError tests * Add check for revert before sending tx * Update web3-plugin-example test to account for getRevertReason check * Turn off checkRevertBeforeSending for sendFewTxes helper * Fix test data for send_signed_transaction tests * Fix bug in get_transaction_error * Fix send_transaction error test * Add checkRevertBeforeSending: false to sendTransaction calls in Contract class * Add checkRevertBeforeSending: false for send tx test helpers * Remove getRevertReason mock * A fix at `IpcProvider` and few changes at `SocketProvider` and its descendants (#5891) * rename `_providerOptions` to `_socketOptions` * pass `_socketOptions` from IpcProvider constructor to the underlying connection * move a comment to its correct position at `SocketProvider` * expose the getter of `SocketConnection` from `SocketProvider`. * update CHANGELOG.md files * add extremely simple unit test for SocketProvider * Fix failed tx test for ganache * Update expected transaction errors for ganache * Fix method handler crashed (#5905) * version fix * use geth binary * try 1.11.2 * Test fix * Use `v1` instead of Short Sha for cloudflare/pages-action (#5909) * use `v1` instead of short Sha for cloudflare/pages-action --------- Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com> Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com> Co-authored-by: Nikos Iliakis <nikoulai@users.noreply.github.com> Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com> Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix failing ens events tests
Checklist for 4.x:
yarnsuccessfullyyarn lintsuccessfullyyarn build:websuccessfullyyarn test:unitsuccessfullyyarn test:integrationsuccessfullycompile:contractssuccessfullyCHANGELOG.mdfile in the packages I have edited.