Zk sync plugin related changes #7174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avkos
requested review from
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 330e8ad | Previous: 61e9e06 | Ratio |
|---|---|---|---|
processingTx |
8994 ops/sec (±4.19%) |
8729 ops/sec (±4.67%) |
0.97 |
processingContractDeploy |
38209 ops/sec (±6.96%) |
37973 ops/sec (±6.91%) |
0.99 |
processingContractMethodSend |
15147 ops/sec (±8.21%) |
15996 ops/sec (±6.56%) |
1.06 |
processingContractMethodCall |
27269 ops/sec (±8.14%) |
27488 ops/sec (±6.50%) |
1.01 |
abiEncode |
43598 ops/sec (±6.49%) |
43224 ops/sec (±7.07%) |
0.99 |
abiDecode |
29286 ops/sec (±7.65%) |
29694 ops/sec (±7.87%) |
1.01 |
sign |
1528 ops/sec (±0.87%) |
1501 ops/sec (±3.13%) |
0.98 |
verify |
363 ops/sec (±0.68%) |
368 ops/sec (±0.51%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7174 +/- ##
=======================================
Coverage 94.45% 94.46%
=======================================
Files 215 215
Lines 8391 8399 +8
Branches 2313 2315 +2
=======================================
+ Hits 7926 7934 +8
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
luu-alex
reviewed
Jul 30, 2024
| @@ -170,6 +170,23 @@ export const hashMessage = (message: string): string => { | |||
| return sha3Raw(ethMessage); // using keccak in web3-utils.sha3Raw instead of SHA3 (NIST Standard) as both are different | |||
| }; | |||
|
|
|||
| export const pureSign = (hash: HexString, privateKey: Bytes): SignResult => { | |||
There was a problem hiding this comment.
I think it makes more sense to Change pureSign to signMessageWithPrivateKey
luu-alex
approved these changes
Jul 30, 2024
jdevcs
reviewed
Jul 31, 2024
| @@ -170,6 +170,23 @@ export const hashMessage = (message: string): string => { | |||
| return sha3Raw(ethMessage); // using keccak in web3-utils.sha3Raw instead of SHA3 (NIST Standard) as both are different | |||
| }; | |||
|
|
|||
| export const signMessageWithPrivateKey = (hash: HexString, privateKey: Bytes): SignResult => { | |||
There was a problem hiding this comment.
@avkos pls add doc comments before merging
jdevcs
approved these changes
Jul 31, 2024
Merged
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.