Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #134 META object with namespace in invoked plugin is empty #135

Merged
merged 7 commits into from
Oct 26, 2018

Conversation

kecso
Copy link
Member

@kecso kecso commented Oct 25, 2018

No description provided.

@kecso kecso added this to the v2.22.0 milestone Oct 25, 2018
@kecso kecso requested a review from pmeijer October 25, 2018 18:18
Copy link
Contributor

@pmeijer pmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestions (which can be accepted via github)

src/plugin/PluginBase.js Outdated Show resolved Hide resolved
test/plugin/scenarios/InvokeScenarios.spec.js Outdated Show resolved Hide resolved
Patrik Meijer and others added 3 commits October 25, 2018 17:32
Co-Authored-By: kecso <tamas.kecskes@vanderbilt.edu>
Co-Authored-By: kecso <tamas.kecskes@vanderbilt.edu>
@pmeijer pmeijer merged commit 0fa7709 into master Oct 26, 2018
@pmeijer pmeijer deleted the bad_plugin_meta branch October 29, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants