Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements in component templates for plugin generators #147

Merged
merged 3 commits into from
Dec 19, 2018
Merged

Minor improvements in component templates for plugin generators #147

merged 3 commits into from
Dec 19, 2018

Conversation

pmeijer
Copy link
Contributor

@pmeijer pmeijer commented Dec 18, 2018 •
edited
Loading

  • Generate scss-files where applicable
  • Harmonize connector sizes
  • Remove unnecessary __proto__ variables
  • Use named constructor functions

This also fixes #146 PLUGIN_NOTIFICATION not dispatched from client.

@pmeijer pmeijer requested a review from kecso December 18, 2018 22:17
@pmeijer pmeijer added this to the v2.22.2 milestone Dec 18, 2018
@kecso kecso merged commit 24e2692 into master Dec 19, 2018
@pmeijer pmeijer deleted the component-templates-updates branch December 20, 2018 18:00
@pmeijer pmeijer changed the title Minor improvements in component templates updates Minor improvements in component templates for plugin generators Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kecso kecso kecso approved these changes

Assignees

@kecso kecso

Labels
Enhancement Minor Plugin
Projects
None yet
Milestone
v2.22.2
Development

Successfully merging this pull request may close these issues.

PLUGIN_NOTIFICATION not dispatched from client
2 participants
@pmeijer @kecso