Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show access token ID on creation. Closes #188 #189

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

brollb
Copy link
Collaborator

@brollb brollb commented Mar 5, 2020

No description provided.

@brollb brollb requested a review from kecso March 5, 2020 16:31
@brollb
Copy link
Collaborator Author

brollb commented Mar 5, 2020

The failing test is related to the speed of the rust-based hash generation:
DeepinScreenshot_select-area_20200305155211

@kecso - thoughts?

@kecso
Copy link
Member

kecso commented Mar 6, 2020

Its a nice to have test and usually rust+webassembly wins, but as you can see sometimes it is not the case...

@kecso kecso merged commit 411db48 into master Mar 6, 2020
@kecso kecso deleted the 188-hide-access-token-value branch May 1, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants