Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #29 addLibrary and updateLibrary from seed possible #31

Merged
merged 3 commits into from
Dec 13, 2017
Merged

Fixes #29 addLibrary and updateLibrary from seed possible #31

merged 3 commits into from
Dec 13, 2017

Conversation

pmeijer
Copy link
Contributor

@pmeijer pmeijer commented Dec 12, 2017

This PR also:

  • removes a bunch of duplicate code in worker-requests.
  • make util.getSeedDictionary asynchronous (for old function use util.getSeedDictionarySync)

@pmeijer pmeijer added this to the v2.19.0 milestone Dec 12, 2017
@pmeijer pmeijer self-assigned this Dec 12, 2017
@pmeijer pmeijer requested a review from kecso December 12, 2017 20:42
@pmeijer pmeijer assigned kecso and unassigned pmeijer Dec 13, 2017
@kecso kecso merged commit e0424e4 into master Dec 13, 2017
@pmeijer pmeijer deleted the library-import-from-seed branch December 13, 2017 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kecso kecso kecso approved these changes

Assignees

@kecso kecso

Labels
Enhancement Minor Server worker
Projects
None yet
Milestone
v2.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pmeijer @kecso