Enable plugins to be required without requirejs and passed to manager as "class" #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main use-case for this is to enable browser side execution of plugins when from an app specific build (with e.g. webpack) bundling the plugins and using
webgme.build.classes.jsto access the client.This approach enables bundling the files without relying on requirejs (and replicating the configuration in webgme). In the future all common, plugin, client, etc. files should probably be converted to support commonJS (node "require") as well. If so, the entire client API could be made part of the bundle as well and the
webgme.build.classes.jswouldn't have to be used.