Minor perf tweaks (PowerShell#5289)

* Avoid creating scriptblocks unnecessarily in PSScriptProperty * Use string.IsNullOrWhiteSpace instead of Trim().Length
webmote · Nov 1, 2017 · c75357b · c75357b
1 parent d43b2cf
commit c75357b
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/src/Microsoft.PowerShell.Commands.Management/commands/management/WebServiceProxy.cs b/src/Microsoft.PowerShell.Commands.Management/commands/management/WebServiceProxy.cs
@@ -150,7 +150,7 @@ public SwitchParameter UseDefaultCredential
         /// </summary>
         protected override void BeginProcessing()
         {
-            if (_uri.ToString().Trim().Length == 0)
+            if (string.IsNullOrWhiteSpace(_uri.ToString()))
             {
                 Exception ex = new ArgumentException(WebServiceResources.InvalidUri);
                 ErrorRecord er = new ErrorRecord(ex, "ArgumentException", ErrorCategory.InvalidOperation, null);

diff --git a/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs b/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs
@@ -2434,7 +2434,7 @@ internal void Run(bool inputLoopIsNested)
                             continue;
                         }
 
-                        if (line.Trim().Length == 0)
+                        if (string.IsNullOrWhiteSpace(line))
                         {
                             if (inBlockMode)
                             {

diff --git a/src/System.Management.Automation/engine/ErrorPackage.cs b/src/System.Management.Automation/engine/ErrorPackage.cs
@@ -901,7 +901,7 @@ private string BuildMessage(
             string resourceId,
             params object[] args)
         {
-            if (String.IsNullOrEmpty(template) || 1 >= template.Trim().Length)
+            if (string.IsNullOrWhiteSpace(template))
             {
                 _textLookupError = PSTraceSource.NewInvalidOperationException(
                     ErrorPackage.ErrorDetailsEmptyTemplate,

diff --git a/src/System.Management.Automation/engine/InitialSessionState.cs b/src/System.Management.Automation/engine/InitialSessionState.cs
@@ -195,7 +195,7 @@ public sealed class SessionStateTypeEntry : InitialSessionStateEntry
         public SessionStateTypeEntry(string fileName)
             : base(fileName)
         {
-            if (String.IsNullOrEmpty(fileName) || fileName.Trim().Length == 0)
+            if (string.IsNullOrWhiteSpace(fileName))
             {
                 throw PSTraceSource.NewArgumentException("fileName");
             }
@@ -300,7 +300,7 @@ public sealed class SessionStateFormatEntry : InitialSessionStateEntry
         public SessionStateFormatEntry(string fileName)
             : base("*")
         {
-            if (String.IsNullOrEmpty(fileName) || fileName.Trim().Length == 0)
+            if (string.IsNullOrWhiteSpace(fileName))
             {
                 throw PSTraceSource.NewArgumentException("fileName");
             }

diff --git a/src/System.Management.Automation/engine/MshMemberInfo.cs b/src/System.Management.Automation/engine/MshMemberInfo.cs
@@ -1782,7 +1782,7 @@ public override bool IsSettable
         {
             get
             {
-                return this.SetterScript != null;
+                return this._setterScript != null || this._setterScriptText != null;
             }
         }
 
@@ -1793,7 +1793,7 @@ public override bool IsGettable
         {
             get
             {
-                return this.GetterScript != null;
+                return this._getterScript != null || this._getterScriptText != null;
             }
         }
 

diff --git a/src/System.Management.Automation/engine/hostifaces/Parameter.cs b/src/System.Management.Automation/engine/hostifaces/Parameter.cs
@@ -49,7 +49,7 @@ public CommandParameter(string name, object value)
         {
             if (name != null)
             {
-                if (name.Trim().Length == 0)
+                if (string.IsNullOrWhiteSpace(name))
                 {
                     throw PSTraceSource.NewArgumentException("name");
                 }
@@ -105,7 +105,7 @@ internal static CommandParameter FromCommandParameterInternal(CommandParameterIn
 
                 Diagnostics.Assert(name != null, "'name' variable should be initialized at this point");
                 Diagnostics.Assert(name[0].IsDash(), "first character in parameter name must be a dash");
-                Diagnostics.Assert(name.Trim().Length != 0, "Parameter name has to have some non-whitespace characters in it");
+                Diagnostics.Assert(name.Trim().Length != 1, "Parameter name has to have some non-whitespace characters in it");
             }
 
             if (internalParameter.ParameterAndArgumentSpecified)