Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

fix: limit must allow infinity and max value #192

Merged
merged 1 commit into from
Oct 3, 2019
Merged

fix: limit must allow infinity and max value #192

merged 1 commit into from
Oct 3, 2019

Conversation

threequartersjohn
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

The limit option did not perform as expected when given Infinity or Number.MAX_VALUE, offloading files into the fallback loader. With this PR those are now valid options.

Breaking Changes

None.

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Oct 3, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #192 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #192   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          38     40    +2     
  Branches       10     11    +1     
=====================================
+ Hits           38     40    +2
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9dbd1...e50357e. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants