Upgrade to es6 #30
Upgrade to es6 #30
Conversation
|
Hey @montogeek would you mind syncing with master and then check tests again. Since we just dropped 0.12, I think its time to dust this off and get to work. webpack/webpack#3605 |
|
@TheLarkInn Synced, tests pass 💃 |
| class MemoryFileSystemError extends Error { | ||
| constructor(err, path) { | ||
| super(err, path); | ||
| if (Error.captureStackTrace) |
There was a problem hiding this comment.
Isn't this always the case for node >= 4?
There was a problem hiding this comment.
Could you add an engine field to package.json (see webpack's package.json)?
Also, the CI fails now because it only runs on old Node.js versions. You can modify the .travis.yml file to only run for Node v4 and Node v6.
|
Sure! |
Current coverage is 96.07% (diff: 99.41%)@@ master #30 diff @@
==========================================
Files 3 3
Lines 272 280 +8
Methods 37 36 -1
Messages 0 0
Branches 62 62
==========================================
+ Hits 261 269 +8
Misses 11 11
Partials 0 0
|
| - "0.12" | ||
| - "iojs" | ||
| - "4" | ||
| - "6" |
| { | ||
| "env": { | ||
| "node": true, | ||
| "es6": true |
|
Coveralls says that the coverage decreased, but those lines were already uncovered in |
|
Looks good to me @d3viant0ne will likely come back around to update the Travis file to conform to standards. Thank you very much!! |
|
Thanks @TheLarkInn !! |
This PR upgrades code to ES6.
All tests pass.
Added EditorConfig and ESLint configs to make it easier for future contributions.
createWriteStreamaccepted a second parameter calledoptions, I removed since it is not being used, although Node implementation uses it: https://nodejs.org/api/fs.html#fs_fs_createwritestream_path_options https://github.com/nodejs/node/blob/master/lib/fs.js#L1878