Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the --progress option with the serve command #2265

Merged
merged 1 commit into from
Dec 26, 2020
Merged

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

bugfx

Did you add tests for your changes?

Yes

If relevant, did you update the documentation?

No need

Summary

fixes #2262

Does this PR introduce a breaking change?

No need to send --progress option to webpack-dev-server, webpack-cli do it (side effect from this fix, no progress in console in webpack-dev-server, but I found it is bug too, very spammy, this behaviour already fixed in webpack-dev-server@4)

Other information

No

@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #2265 (f644705) into master (7c2311a) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2265      +/-   ##
==========================================
- Coverage   67.83%   67.82%   -0.02%     
==========================================
  Files          64       63       -1     
  Lines        2416     2415       -1     
  Branches      544      544              
==========================================
- Hits         1639     1638       -1     
  Misses        777      777              
Impacted Files Coverage Δ
packages/serve/src/startDevServer.ts 81.39% <80.00%> (-0.66%) ⬇️
packages/serve/src/index.ts 59.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2311a...f644705. Read the comment docs.

@alexander-akait alexander-akait merged commit 952a188 into master Dec 26, 2020
@alexander-akait alexander-akait deleted the issue-2262 branch December 26, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4.3.0] can no longer use --progress
2 participants