Removing watching/watching.running check #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ibash, PR seems good. Could you verify that it still is necessary (it's been a while), and if so, fix the merge conflict? Will merge after that. |
Given that `state` should always have the correct value (if the bundle is valid or not) then we should be able to use ready directly without checking the watcher. I also hit a bug where the watcher had running set to false while the bundle was invalid, leading to a callback being executed immediately instead of waiting.
ibash
force-pushed
the
remove_block_on_running
branch
from
9aa2abf
to
6b6fbbb
Compare
|
Fixed the merge conflict. I'm not using this change myself anymore, but looking over it again I think it is still valid. |
|
Thank you! |
wuct
added a commit
to wuct/webpack-dev-middleware
that referenced
this pull request
Sep 12, 2016
…eware * 'master' of https://github.com/webpack/webpack-dev-middleware: committed too quickly... Add not-functional test for server side render More tests fix typos Start with some tests! Fix inconsistencies with semi colons Use valid license for npm Document `reporter` option Add changelog for 1.7.0 1.7.0 Removing watching/watching.running check (webpack#100) Improve eslint linting and remove js-beautify Support for server-side rendering (webpack#118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that
stateshould always have the correct value (if the bundle is validor not) then we should be able to use ready directly without checking the
watcher.
I also hit a bug where the watcher had running set to false while the bundle was
invalid, leading to a callback being executed immediately instead of waiting.
Fixes #107