Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added charset=UTF-8 to content-type to fix encoding issues. #136

Merged
merged 2 commits into from
Oct 5, 2016

Conversation

callumacrae
Copy link
Contributor

@callumacrae callumacrae commented Oct 4, 2016

Fixes webpack/webpack-dev-server#432

This hasn't broken anything for me.

@SpaceK33z
Copy link
Member

Could you fix the tests?

@callumacrae
Copy link
Contributor Author

@SpaceK33z: heh, was just pushing the fix when you said that!

@SpaceK33z
Copy link
Member

Thanks, looks like it doesn't break anything.

@SpaceK33z SpaceK33z merged commit e192bba into webpack:master Oct 5, 2016
@callumacrae
Copy link
Contributor Author

Thanks! 🎉

@rebers
Copy link

rebers commented Oct 7, 2016

When can we expect a release including this? Would make testing languages other than English much easier to test (i.e. no building needed).

Thanks!

@SpaceK33z
Copy link
Member

SpaceK33z commented Oct 8, 2016

Released in 1.8.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants