Improve getFilenameFromUrl to work with proxy requests

[ijse]

This fix issue dvdzkwsk/react-redux-starter-kit#666 and as well Express 4 that req.path is undefined in some situation.

[jhnns]

Sorry, I've reverted your commit (b05cd04) because it broke a lot of code out there (#79 #81 #82).

Could you tell me what the purpose of b05cd04 was?

I'm not sure if I'm understanding this PR correctly, but it looks to me that it does not cover the old implementation. I won't merge this PR until its purpose is clear to me.

Sorry again, that we don't have any tests yet. It makes contributing a lot harder. It's certainly not your fault.

[ijse]

I use webpack-dev-server and express, and SwitchOmega Plugin to proxy requests to the localhost. so that the request hostname won't match because options.publicPath='/xxx', the getFilenameFromUrlwill return false.

I wrote this gist to explain the case:

https://gist.github.com/ijse/ffa06369190ebfe4ac11

[SpaceK33z]

@ijse, is it not possible to exclude dev-server from the proxy? Also see webpack/webpack-dev-server#600 (comment). Not excluding the dev-server seems to result in more issues after this.

[SpaceK33z]

I recently added extensive tests for the getFilenameFromUrl method, so this will be a lot easier to test.

[SpaceK33z]

Could you fix the merge conflict, and make sure it passes the new tests (npm test)?

[SpaceK33z]

Looks very good, I like how it also makes the code somewhat easier to read.

If you fix the issues with RegExp, I'll merge it :).

[SpaceK33z]

Inserting publicPath into RegExp can lead to unexpected errors, since the string will be interpreted as regex.

Maybe use lastIndexOf?

[ijse]

lastIndexOf or indexOf ?

{
    url: "/more/complex/path.js",
    outputPath: "/a",
    publicPath: "/complex"
}

Is it expected to be false?

[SpaceK33z]

I think lastIndexOf, see this question.

Yes, the example you've given is expected to be false, because publicPath is not in the url. Would be nice if you add your example to the tests.

[SpaceK33z]

Ah, just saw your changes with indexOf, that's also ok.

[SpaceK33z]

Same with the RegExp as above.

[SpaceK33z]

One more thing, could you add a testcase that failed before, but is fixed now? Otherwise someone could refactor it again and stop your usecase from working ;).

[SpaceK33z]

Thank you!