Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use middleware for 'GET' requests #96

Merged
merged 1 commit into from
Sep 4, 2016

Conversation

alexprice1
Copy link
Contributor

@alexprice1 alexprice1 commented May 16, 2016

Doesn't make sense to for the middleware on all routes.

@alexprice1
Copy link
Contributor Author

@sokra looks like updates to middleware are somewhat slow. I think this is a pretty usual requirement for this package, even if its just for development. Should I fork this repo and work from there instead?

@SpaceK33z
Copy link
Member

What is the usecase for this?

@alexprice1
Copy link
Contributor Author

Let's say I have an endpoint GET /login.
It takes me to a login form and webpack-dev-middleware delivers that.

Then I have another endpoint POST /login, this endpoint actually logs a user in.

@SpaceK33z
Copy link
Member

Thanks!

Small feedback thingy for next time: in the commit title, tell why you've changed something, instead of telling what file; we can already see that in the diff.

@SpaceK33z
Copy link
Member

Released in 1.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants