Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle module.require, require.main.require, and module.parent.require #7750

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

ak-14
Copy link
Contributor

@ak-14 ak-14 commented Jul 19, 2018

  • Resolve module.require dependencies

  • Add require.main.require and module.parent.require as unsupported

Issue #7728: Detect module.require dependency

What kind of change does this PR introduce?
Parser enhancement

Did you add tests for your changes?
Yes

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?

  1. Webpack can detect and resolve module.require
  2. Webpack does not support require.main.require and module.parent.require

- Resolve module.require dependencies

- Add require.main.require and module.parent.require as unsupported
@jsf-clabot
Copy link

jsf-clabot commented Jul 19, 2018

CLA assistant check
All committers have signed the CLA.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 699fe21 into webpack:master Jul 23, 2018
@sokra
Copy link
Member

sokra commented Jul 23, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants