eslint: prefer type import

Note to downstream users, this does not change any behavior after compilation, so this is not marked as breaking change.

.eslintrc.json

@@ -40,6 +40,9 @@
     ],
     "require-atomic-updates": [
       0
+    ],
+    "@typescript-eslint/consistent-type-imports": [
+      "error", { "disallowTypeAnnotations": false }
     ]
   }
-}
+}

src/mdn/browser-compatibility-table/feature-row.ts

@@ -1,5 +1,6 @@
 /* eslint-disable @typescript-eslint/no-non-null-assertion */
 import type * as BCD from './types';
+import type {SupportStatementExtended} from './utils';
 import {
   asList,
   bugURLToString,
@@ -9,7 +10,6 @@ import {
   isFullySupportedWithoutLimitation,
   isNotSupportedAtAll,
   isTruthy,
-  SupportStatementExtended,
   versionIsPreview,
 } from './utils';
 import {LEGEND_LABELS} from './legend';

src/mdn/custom-dns-lookup.ts

@@ -1,6 +1,5 @@
-import CacheableLookup, {
-  EntryObject, Options
-} from 'cacheable-lookup';
+import type {EntryObject, Options} from 'cacheable-lookup';
+import CacheableLookup from 'cacheable-lookup';
 
 export function preferIpv6Comparator(a: EntryObject, b: EntryObject): number {
   return b.family - a.family;

src/mdn/decompress-sitemap.ts

@@ -1,7 +1,8 @@
 import type {DownloadResource} from 'website-scrap-engine/lib/life-cycle/types';
 import {ResourceType} from 'website-scrap-engine/lib/resource';
 import {promisify} from 'util';
-import {gunzip, InputType} from 'zlib';
+import type {InputType} from 'zlib';
+import {gunzip} from 'zlib';
 
 const gunzipAsync = promisify(gunzip);
 

src/mdn/download-and-fallback.ts

@@ -1,6 +1,7 @@
 import type {HTTPError} from 'got';
 import {downloadResource} from 'website-scrap-engine/lib/life-cycle';
-import {Resource, ResourceType} from 'website-scrap-engine/lib/resource';
+import type {Resource} from 'website-scrap-engine/lib/resource';
+import {ResourceType} from 'website-scrap-engine/lib/resource';
 import type {
   DownloadResource,
   RequestOptions

src/mdn/life-cycle.ts

@@ -2,10 +2,8 @@ import {
   defaultLifeCycle,
   downloadResource
 } from 'website-scrap-engine/lib/life-cycle';
-import {
-  defaultDownloadOptions,
-  DownloadOptions
-} from 'website-scrap-engine/lib/options';
+import type {DownloadOptions} from 'website-scrap-engine/lib/options';
+import {defaultDownloadOptions} from 'website-scrap-engine/lib/options';
 import {processHtml} from 'website-scrap-engine/lib/life-cycle/adapters';
 import {skipProcess} from './process-url/skip-process';
 import {redirectUrl} from './process-url/redirect-url';

src/mdn/mdn-merge-samples.ts

@@ -1,4 +1,5 @@
-import glob, {Entry} from 'fast-glob';
+import type {Entry} from 'fast-glob';
+import glob from 'fast-glob';
 import cheerio from 'cheerio';
 import fs from 'fs';
 import path from 'path';

src/mdn/process-html/index.ts

@@ -33,11 +33,11 @@ import {
   preProcessAddIconToExternalLinks
 } from './process-external';
 import {preProcessRemoveElements} from './process-remove-elements';
+import type {ProcessYariDataResult} from './process-yari-data';
 import {
   downloadAndRenderYariCompatibilityData,
   preProcessYariData,
-  preProcessYariHydrationData,
-  ProcessYariDataResult
+  preProcessYariHydrationData
 } from './process-yari-data';
 import {
   postProcessPlayground,

src/mdn/process-html/process-interactive-examples.ts

@@ -1,5 +1,6 @@
 import type {DownloadResource} from 'website-scrap-engine/lib/life-cycle/types';
-import {Resource, ResourceType} from 'website-scrap-engine/lib/resource';
+import type {Resource} from 'website-scrap-engine/lib/resource';
+import {ResourceType} from 'website-scrap-engine/lib/resource';
 import type {Cheerio, CheerioStatic} from 'website-scrap-engine/lib/types';
 
 interface InteractiveExampleResource extends Resource {

src/mdn/process-html/process-playable.ts

@@ -1,5 +1,4 @@
 import type {CheerioStatic} from 'website-scrap-engine/lib/types';
-import {ResourceType} from 'website-scrap-engine/lib/resource';
 
 function trimMatch(text1: string, text2: string): boolean {
   text1 = text1.split('\n').map(line => line.trim()).filter(Boolean).join('\n');

src/mdn/process-html/process-yari-main-css.ts

@@ -1,4 +1,4 @@
-import {
+import type {
   DownloadResource,
   SubmitResourceFunc
 } from 'website-scrap-engine/lib/life-cycle/types';

src/mdn/process-search-json.ts

@@ -3,8 +3,11 @@ import type {
   SubmitResourceFunc
 } from 'website-scrap-engine/lib/life-cycle/types';
 import type {StaticDownloadOptions} from 'website-scrap-engine/lib/options';
-import type {PipelineExecutor} from 'website-scrap-engine/lib/life-cycle/pipeline-executor';
-import {Resource, ResourceType} from 'website-scrap-engine/lib/resource';
+import type {
+  PipelineExecutor
+} from 'website-scrap-engine/lib/life-cycle/pipeline-executor';
+import type {Resource} from 'website-scrap-engine/lib/resource';
+import {ResourceType} from 'website-scrap-engine/lib/resource';
 import {toString} from 'website-scrap-engine/lib/util';
 import {error} from 'website-scrap-engine/lib/logger/logger';
 

src/mdn/process-url/detect-link-type.ts

@@ -1,5 +1,6 @@
 import {arrayToMap} from 'website-scrap-engine/lib/util';
-import {Resource, ResourceType} from 'website-scrap-engine/lib/resource';
+import type {Resource} from 'website-scrap-engine/lib/resource';
+import {ResourceType} from 'website-scrap-engine/lib/resource';
 import type {Cheerio} from 'website-scrap-engine/lib/types';
 
 // manually collected

src/mdn/process-url/drop-resource.ts

@@ -1,5 +1,5 @@
 import {downloadableHosts, localeArr, mdnHosts} from './consts';
-import {Resource} from 'website-scrap-engine/lib/resource';
+import type {Resource} from 'website-scrap-engine/lib/resource';
 import type {StaticDownloadOptions} from 'website-scrap-engine/lib/options';
 import URI from 'urijs';
 import type {Cheerio} from 'website-scrap-engine/lib/types';

test/mdn/process-url/detect-link-type.spec.ts

@@ -1,5 +1,6 @@
 import {detectLinkType} from '../../../src/mdn/process-url/detect-link-type';
-import {Resource, ResourceType} from 'website-scrap-engine/lib/resource';
+import type {Resource} from 'website-scrap-engine/lib/resource';
+import {ResourceType} from 'website-scrap-engine/lib/resource';
 import cheerio from 'cheerio';
 import URI = require('urijs');
 

test/mdn/process-url/redirect-url.spec.ts

@@ -1,7 +1,10 @@
 import {redirectUrl} from '../../../src/mdn/process-url/redirect-url';
-import type {StaticDownloadOptions} from 'website-scrap-engine/lib/options';
-import type {DownloadOptions} from 'website-scrap-engine/lib/options';
-import {Resource, ResourceType} from 'website-scrap-engine/lib/resource';
+import type {
+  DownloadOptions,
+  StaticDownloadOptions
+} from 'website-scrap-engine/lib/options';
+import type {Resource} from 'website-scrap-engine/lib/resource';
+import {ResourceType} from 'website-scrap-engine/lib/resource';
 
 const opt = (locale: string): StaticDownloadOptions => ({
   localRoot: '/tmp/dummy',