Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add error handlers to examples, and improve error event description #2112

Closed
wants to merge 2 commits into from
Closed

Conversation

dyc3
Copy link

@dyc3 dyc3 commented Jan 23, 2023

  • docs: add minimal error handlers to examples
  • docs: indicate that failing to handle an error event will crash the process

@lpinca lpinca closed this in b82682a Jan 23, 2023
@lpinca
Copy link
Member

lpinca commented Jan 23, 2023

There were unrelated changes, some missing handlers, and some nits to fix, so I went ahead and pushed b82682a. I did not change the 'error' event description because crashing on unhandled 'error' events is standard Node.js behavior.

Thank you anyway.

@dyc3 dyc3 deleted the error-examples branch January 23, 2023 21:01
lpinca added a commit that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants