Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ScrollArea's display:table #1447

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Fix ScrollArea's display:table #1447

merged 4 commits into from
Apr 13, 2023

Conversation

rpominov
Copy link
Contributor

@rpominov rpominov commented Apr 13, 2023

Description

This fixes issue with display:table everywhere ScrollArea is used now, unlike the previous fix that only fixed style panel

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • test it on preview
  • hi @istarkov, I need you to do
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Apr 13, 2023 8:43am

@rpominov rpominov changed the title fix scroll area's display:table Fix ScrollArea's display:table Apr 13, 2023
@rpominov rpominov marked this pull request as ready for review April 13, 2023 08:27
@rpominov rpominov requested review from kof and istarkov April 13, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants