adds handling for x-forwarded-for comma-separated syntax #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
|
🎉 Congrats on getting your first pull request landed! |
|
Thanks @tdjsnelling! |
|
🎉 This PR is included in version 10.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added better parsing of the
X-Forwarded-Forheader whentrustProxyis enabled.The
X-Forwarded-Forheader can contain a comma-separated list of IP addresses, the first being the client IP and the rest being the addresses of the proxies that the request passed through.https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For#syntax
There was no handling for this in the server code, so if a list was passed in the header the IP regex test would fail and the peer doing the announce would not be added to the tracker.
This PR adds handling for when the header contains a comma-separated list, by splitting the header on
,and setting theipproperty to only the first value.Which issue (if any) does this pull request address?
None
Is there anything you'd like reviewers to focus on?
I was unable to run the tests on an M1 macbook due to an arch error, so please check tests are passing.