Use tabular nums and fixed width for no jitter on time #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoRBaquero
approved these changes
Aug 28, 2017
|
Do you want to merge this before it starts conflicting with other changes? 馃槄 |
|
This is awesome, sorry it took so long to merge and release 馃憤 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The width of the video time was making me uncomfortable 馃槄, so I fixed by having the numbers be tabular and formatting the time with consideration for the total time.
I was unable to run the integration tests on my 2016 12" Macbook.
I guess using tabular nums could be applied a lot of other places in the app, such as download percentage, file sizes etc.
Before Image:
After image (Added 1h to duration for test purpose):