cyber: refactor WaitEnqueue templates

wei07283091 · Apr 4, 2019 · 0ec8141 · 0ec8141
1 parent 6b63854
commit 0ec8141
Showing 1 changed file with 13 additions and 16 deletions.
diff --git a/cyber/base/bounded_queue.h b/cyber/base/bounded_queue.h
@@ -171,14 +171,13 @@ bool BoundedQueue<T>::WaitEnqueue(const T& element) {
   while (!break_all_wait_) {
     if (Enqueue(element)) {
       return true;
-    } else {
-      if (wait_strategy_->EmptyWait()) {
+    }
+    if (wait_strategy_->EmptyWait()) {
         continue;
-      }
-      // wait timeout
-      return false;
     }
+    // wait timeout
   }
+
   return false;
 }
 
@@ -187,14 +186,13 @@ bool BoundedQueue<T>::WaitEnqueue(T&& element) {
   while (!break_all_wait_) {
     if (Enqueue(element)) {
       return true;
-    } else {
-      if (wait_strategy_->EmptyWait()) {
-        continue;
-      }
-      // wait timeout
-      return false;
     }
+    if (wait_strategy_->EmptyWait()) {
+      continue;
+    }
+    // wait timeout
   }
+
   return false;
 }
 
@@ -203,14 +201,13 @@ bool BoundedQueue<T>::WaitDequeue(T* element) {
   while (!break_all_wait_) {
     if (Dequeue(element)) {
       return true;
-    } else {
-      if (wait_strategy_->EmptyWait()) {
+    }
+    if (wait_strategy_->EmptyWait()) {
         continue;
-      }
-      // wait timeout
-      return false;
     }
+    // wait timeout
   }
+
   return false;
 }