Fix according to review

weichunshen89 · Jun 9, 2021 · 4d73310 · 4d73310
1 parent b773fb3
commit 4d73310
Showing 1 changed file with 6 additions and 20 deletions.
diff --git a/.../src/main/java/org/apache/flink/runtime/io/network/netty/NettyPartitionRequestClient.java b/.../src/main/java/org/apache/flink/runtime/io/network/netty/NettyPartitionRequestClient.java
@@ -127,19 +127,12 @@ public void requestSubpartition(
                     public void operationComplete(ChannelFuture future) throws Exception {
                         if (!future.isSuccess()) {
                             clientHandler.removeInputChannel(inputChannel);
-                            SocketAddress remoteAddr = future.channel().remoteAddress();
-                            String address =
-                                    remoteAddr == null
-                                            ? String.format(
-                                                    "%s (#%d)",
-                                                    connectionId.getAddress(),
-                                                    connectionId.getConnectionIndex())
-                                            : remoteAddr.toString();
                             inputChannel.onError(
                                     new LocalTransportException(
                                             String.format(
-                                                    "Sending the partition request to '%s' failed.",
-                                                    address),
+                                                    "Sending the partition request to '%s (#%d)' failed.",
+                                                    connectionId.getAddress(),
+                                                    connectionId.getConnectionIndex()),
                                             future.channel().localAddress(),
                                             future.cause()));
                         }
@@ -187,19 +180,12 @@ public void sendTaskEvent(
                             @Override
                             public void operationComplete(ChannelFuture future) throws Exception {
                                 if (!future.isSuccess()) {
-                                    SocketAddress remoteAddr = future.channel().remoteAddress();
-                                    String address =
-                                            remoteAddr == null
-                                                    ? String.format(
-                                                            "%s (#%d)",
-                                                            connectionId.getAddress(),
-                                                            connectionId.getConnectionIndex())
-                                                    : remoteAddr.toString();
                                     inputChannel.onError(
                                             new LocalTransportException(
                                                     String.format(
-                                                            "Sending the task event to '%s' failed.",
-                                                            address),
+                                                            "Sending the task event to '%s (#%d)' failed.",
+                                                            connectionId.getAddress(),
+                                                            connectionId.getConnectionIndex()),
                                                     future.channel().localAddress(),
                                                     future.cause()));
                                 }