Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CSI-259): report mount transport in node topology #337

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Sep 18, 2024

TL;DR

Added support for scheduling workloads by transport protocol (NFS or WekaFS) using node topology.

What changed?

  • Updated NFS.md documentation to include information about scheduling workloads by transport protocol.
  • Added constants for NFS and WekaFS data transport types.
  • Implemented getTransport() method for both NFS and WekaFS mounters.
  • Modified NodeGetInfo function to include transport type in node topology.

How to test?

  1. Deploy the updated Weka CSI Plugin in a hybrid cluster having both nodes with weka client installed and not installed, while setting pluginConfig.mountProtocol.allowNfsFailback=true
  2. Create a PVC and a pod with a nodeSelector specifying the desired transport:
    nodeSelector:
      topology.weka.com/transport: wekafs
    or
    nodeSelector:
      topology.weka.com/transport: nfs
  3. Verify that the pod is scheduled on a node with the specified transport type.

Why make this change?

This change allows administrators to optimize workload placement based on the available transport protocol. In hybrid deployments where some nodes have the Weka client installed and others don't, storage-intensive workloads can be directed to nodes with WekaFS transport, while more generic workloads can use NFS transport. This flexibility enhances performance and resource utilization in diverse Kubernetes environments.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sergeyberezansky and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Sep 18, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/18/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

@sergeyberezansky sergeyberezansky added the enhancement New feature or request label Sep 19, 2024 — with Graphite App
@sergeyberezansky sergeyberezansky merged commit b8852c9 into dev Sep 19, 2024
12 checks passed
@sergeyberezansky sergeyberezansky deleted the sergey/topology-transport branch September 29, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant