fix(CSI-274): add sleep before mount if nfs was reconfigured #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sergeyberezansky and the rest of your teammates on |
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (10/08/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
This was referenced Oct 8, 2024
sergeyberezansky
force-pushed
the
sergey/wait-on-nfs-reconfig
branch
from
8a4148f
to
6b30bca
Compare
sergeyberezansky
changed the base branch from
dev
to
sergey/allow-unpublish-on-stale-file-handle
This was referenced Oct 8, 2024
Merge activity
|
sergeyberezansky
changed the base branch from
sergey/allow-unpublish-on-stale-file-handle
to
graphite-base/353
sergeyberezansky
force-pushed
the
sergey/wait-on-nfs-reconfig
branch
from
6b30bca
to
a8f3b3b
Compare
sergeyberezansky
force-pushed
the
sergey/wait-on-nfs-reconfig
branch
from
a8f3b3b
to
2e3c048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactored NFS permission and client group management functions to improve error handling and configuration updates.
What changed?
EnsureNfsPermissionto return a boolean indicating if a new permission was created.EnsureCsiPluginNfsClientGroupto return a boolean for new group creation.EnsureNfsClientGroupRuleForIpto return a boolean for new rule creation.EnsureNfsPermissionsto determine if a wait period is necessary.How to test?
Why make this change?
This refactoring ensures that NFS mount is not attempted right after NFS cluster reconfiguration (which is asynchronous), since otherwise it might fail.
The delay is added only upon config change is inflicted, reducing unnecessary waits when configurations already exist.
These changes will lead to better performance and more reliable NFS setup processes in the CSI plugin, as well as shorter provisioning time