Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CSI-282): make async default for NFS mounts #362

Merged
merged 1 commit into from
Oct 10, 2024
Merged

feat(CSI-282): make async default for NFS mounts #362

merged 1 commit into from
Oct 10, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Oct 10, 2024 •
edited
Loading

Mount Options Enhancements and Tests

  • Added comprehensive unit tests for MountOptions functionality
  • Implemented GetOptionValue(optstr) method for MountOptions
  • Added "rw" and "ro" to the list of mutually exclusive mount options
  • Removed automatic mapping of "sync_on_close" to "sync" in NFS conversion
  • Updated default NFS mount options to include "hard" and "async"

@graphite-app graphite-app bot requested a review from tigrawap October 10, 2024 16:04
@sergeyberezansky Graphite App
Copy link
Collaborator Author

sergeyberezansky commented Oct 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sergeyberezansky and the rest of your teammates on Graphite Graphite

@sergeyberezansky sergeyberezansky mentioned this pull request Oct 10, 2024
Merged
@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 10, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (10/10/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

@sergeyberezansky Graphite App
Copy link
Collaborator Author

sergeyberezansky commented Oct 10, 2024 •
edited
Loading

Merge activity

  • Oct 10, 12:13 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 10, 12:27 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 10, 12:30 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 10, 12:49 PM EDT: A user merged this pull request with Graphite.

@sergeyberezansky sergeyberezansky changed the base branch from sergey/add-trace-to-grpc-logging to graphite-base/362 October 10, 2024 16:26
@sergeyberezansky sergeyberezansky changed the base branch from graphite-base/362 to dev October 10, 2024 16:26
@sergeyberezansky
feat(CSI-282): make async default for NFS mounts
66a75f5 
- Add tests for mountoptions
- add GetOptionValue(optstr) for MountOptions
- Add rw,ro as mutually exclusive
- Remove automatic sync mapping for sync_on_close
@sergeyberezansky sergeyberezansky merged commit c7dfcc3 into dev Oct 10, 2024
12 checks passed
@sergeyberezansky sergeyberezansky deleted the sergey/make-async-default branch October 15, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrawap tigrawap Awaiting requested review from tigrawap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sergeyberezansky