feat(CSI-286): whitespace not trimmed for localContainerName in CSI secret

[sergeyberezansky]

TL;DR

Improved handling of localContainerName in the fromSecrets function.

What changed?

• Modified the fromSecrets function in pkg/wekafs/wekafs.go.
• Added trimming of whitespace and newline characters from localContainerName.
• Restructured the conditional logic for handling the presence of localContainerName in secrets.

How to test?

1. Provide secrets with localContainerName containing leading/trailing whitespace or newline characters, e.g. when the string is encoded into Base64 together with a trailing newline
2. Call the fromSecrets function with these secrets.
3. Verify that the resulting localContainerName is properly trimmed.
4. Test with and without localContainerName in the secrets to ensure correct behavior in both cases.

Why make this change?

This change improves the robustness of the fromSecrets function by ensuring that localContainerName is properly sanitized. It prevents potential issues caused by unintended whitespace or newline characters, which could lead to unexpected behavior in downstream operations that rely on this value.

[sergeyberezansky]

• feat(CSI-287): acl not passed to NFS mount in ControllerCreateVolume flow #366
• feat(CSI-286): whitespace not trimmed for localContainerName in CSI secret #364 👈
• feat(CSI-288): validate API user role prior to performing ops #365
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sergeyberezansky and the rest of your teammates on Graphite

[graphite-app]

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (10/13/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.