Skip to content

Commit

Permalink
Fix the install of TensorBoard for doc generation (pytorch#19814)
Browse files Browse the repository at this point in the history
Summary:
One more fix for pytorch#19810

We now know that we are running with python3, so no need to check python version. The quotes were probably causing problems here.

cc ezyang soumith zou3519
Pull Request resolved: pytorch#19814

Differential Revision: D15106459

Pulled By: orionr

fbshipit-source-id: 0443b9b54d17fead9c8c2c9d8d2f373e1f95a28b
  • Loading branch information
orionr authored and facebook-github-bot committed Apr 26, 2019
1 parent be20d65 commit 1129770
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 14 deletions.
9 changes: 2 additions & 7 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,8 @@ install_doc_push_script: &install_doc_push_script
rm -rf pytorch || true
# Install TensorBoard so torch.utils.tensorboard classes render
PYTHON_VERSION=$(python -c 'import platform; print(platform.python_version())'|cut -c1)
if [[ $PYTHON_VERSION == "2" ]]; then
pip install -q https://s3.amazonaws.com/ossci-linux/wheels/tensorboard-1.14.0a0-py2-none-any.whl
else
pip install -q https://s3.amazonaws.com/ossci-linux/wheels/tensorboard-1.14.0a0-py3-none-any.whl
fi
# Install TensorBoard in python 3 so torch.utils.tensorboard classes render
pip install -q https://s3.amazonaws.com/ossci-linux/wheels/tensorboard-1.14.0a0-py3-none-any.whl
# Get all the documentation sources, put them in one place
pushd "\$pt_checkout"
Expand Down
9 changes: 2 additions & 7 deletions .circleci/verbatim-sources/header-section.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,8 @@ install_doc_push_script: &install_doc_push_script
rm -rf pytorch || true
# Install TensorBoard so torch.utils.tensorboard classes render
PYTHON_VERSION=$(python -c 'import platform; print(platform.python_version())'|cut -c1)
if [[ $PYTHON_VERSION == "2" ]]; then
pip install -q https://s3.amazonaws.com/ossci-linux/wheels/tensorboard-1.14.0a0-py2-none-any.whl
else
pip install -q https://s3.amazonaws.com/ossci-linux/wheels/tensorboard-1.14.0a0-py3-none-any.whl
fi
# Install TensorBoard in python 3 so torch.utils.tensorboard classes render
pip install -q https://s3.amazonaws.com/ossci-linux/wheels/tensorboard-1.14.0a0-py3-none-any.whl
# Get all the documentation sources, put them in one place
pushd "\$pt_checkout"
Expand Down

0 comments on commit 1129770

Please sign in to comment.