Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always use half of available parallelism #611

Merged
merged 4 commits into from
Jul 27, 2024

Conversation

mrazauskas
Copy link
Contributor

Not sure if that was intentional. While calculating concurrency, current logic is takes half of availableParallelism(), but os.cpus().length is not divided by 2. So I though to fix this.

Also documentation needs an adjustment.

src/polyfills/cpus.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (cf22b0a) to head (84573ba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   98.90%   97.70%   -1.20%     
==========================================
  Files          26       33       +7     
  Lines        1646     1788     +142     
  Branches        9       15       +6     
==========================================
+ Hits         1628     1747     +119     
- Misses         12       26      +14     
- Partials        6       15       +9     
Flag Coverage Δ
linux ?
osx 97.70% <100.00%> (-0.90%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel
Copy link
Owner

There is no need for immediate release or so.

Thanks @mrazauskas, especially for updating documentation. I'm fixing the #608, I'll release both together 🙋🏻‍♂️

@wellwelwel wellwelwel merged commit 4c3f289 into wellwelwel:main Jul 27, 2024
28 checks passed
@mrazauskas mrazauskas deleted the fix-availableParallelism branch July 27, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants