Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): enforce flags validation #699

Merged
merged 6 commits into from
Aug 20, 2024
Merged

feat(cli): enforce flags validation #699

merged 6 commits into from
Aug 20, 2024

Conversation

wellwelwel
Copy link
Owner

@wellwelwel wellwelwel commented Aug 20, 2024

Closes #647.


To enable this feature, use the --enforce or -x flags.


  • The choice for enforce instead of strict (my preference) is to avoid ambiguity with the strict assertion method.
  • Although it's interesting to display warnings for user mistakes by default, at the moment I have no intention to show warnings due to flags unknown to Poku (perhaps in the next major version).

Important

This option is dynamic (not limited to a single effect) and is intended to ensure that the execution is valid and secure before continuing with the tests.

@wellwelwel wellwelwel added the cli label Aug 20, 2024
@wellwelwel wellwelwel marked this pull request as ready for review August 20, 2024 03:43
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (203fb45) to head (3a4d764).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
+ Coverage   98.58%   98.73%   +0.15%     
==========================================
  Files          36       36              
  Lines        1902     1902              
  Branches        9       11       +2     
==========================================
+ Hits         1875     1878       +3     
+ Misses         18       16       -2     
+ Partials        9        8       -1     
Flag Coverage Δ
linux 98.52% <ø> (?)
osx 98.58% <ø> (ø)
windows 98.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel merged commit 4477de1 into main Aug 20, 2024
22 checks passed
@wellwelwel wellwelwel deleted the enforce branch August 20, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate CLI flags
1 participant