add WPS356 violation related to unneccessary iterable unpacking #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2520
💛 - Coveralls |
sobolevn
reviewed
Jan 26, 2020
| @@ -50,9 +48,7 @@ def test_augmented_assign( | |||
| @pytest.mark.parametrize('code', [ | |||
| 'a = a {0} b', | |||
| ]) | |||
| @pytest.mark.parametrize('operation', [ | |||
There was a problem hiding this comment.
That's what I love about new linter rules! It allows to find errors even here!
| first, *iterable = other_iterable | ||
|
|
||
| # Wrong: | ||
| [*iterable] |
There was a problem hiding this comment.
I guess we should also show how to handle this situation. Let's add list(iterable) to the correct examples.
|
By the way, @skarzi can you please update the I forgot about it. |
sobolevn
approved these changes
Jan 26, 2020
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Checklist
CHANGELOG.mdRelated issues
Closes: #1101
🙏 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.