Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 255: Forbid using multiple for in comprehensions #270

Merged
merged 4 commits into from
Oct 17, 2018
Merged

Issue 255: Forbid using multiple for in comprehensions #270

merged 4 commits into from
Oct 17, 2018

Conversation

tommbee
Copy link
Contributor

@tommbee tommbee commented Oct 17, 2018

I have made things!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

@coveralls
Copy link

coveralls commented Oct 17, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 515

  • 25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 511: 0.0%
Covered Lines: 1349
Relevant Lines: 1349
💛 - Coveralls

sobolevn
sobolevn requested changes Oct 17, 2018
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me! Please, fix a single comment and it will be ready.

Awesome work!

wemake_python_styleguide/violations/complexity.py Show resolved Hide resolved
@sobolevn sobolevn merged commit 2544373 into wemake-services:master Oct 17, 2018
@sobolevn sobolevn mentioned this pull request Oct 17, 2018
Closed
@sobolevn
Copy link
Member

@tommbee thanks a lot!

Please, tell me: do you this linter at work? Do you have any feedback?

@tommbee
Copy link
Contributor Author

tommbee commented Oct 17, 2018

@tommbee thanks a lot!

Please, tell me: do you this linter at work? Do you have any feedback?

Have used it on personal projects. Great little tool, Its helped define my Python coding style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tommbee @coveralls @sobolevn