Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/update package #5

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

jorgesarabia
Copy link

Update some imports in webview-umbrella.h to solve the issues #3 and #4

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ghost
Copy link

ghost commented Apr 19, 2022

Hello,

When this PR will be applied please :'( ?

@ghost
Copy link

ghost commented Apr 25, 2022

up

@rafayrao97
Copy link

hi facing same issue , please let me know what to do ?

@rafayrao97
Copy link

up

Facing the same issue ,let me know should I only. change the version or there are other things to change?

@ghost
Copy link

ghost commented May 19, 2022

up

@ivanthecrazy
Copy link

@wenzhiming Please approve

@wenzhiming wenzhiming merged commit 399170b into wenzhiming:dev Jun 2, 2022
@waleedsyal123
Copy link

Definition of 'FLTCookieManager' must be imported from module 'webview_flutter_wkwebview.FLTCookieManager' before it is required
I am getting error on ios device, Can you provide some info when it will be fixed
Thanks

@waleedsyal123
Copy link

waleedsyal123 commented Aug 3, 2022

Some help regarding this issue in ios: Please anyone

Modules Issue (Xcode): Definition of 'FLTCookieManager' must be imported from module 'webview_flutter_wkwebview.FLTCookieManager' before it is required
/Users/apple/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FLTCookieManager.m:7:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants